Demo code changes #718
Closed
Demo code changes #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyzooghost
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
| _pauseTypeStatusesBitMap &= ~(1 << uint256(_pauseType)); | ||
| emit UnPaused(_msgSender(), _pauseType); | ||
| } | ||
|
|
||
| /** | ||
| * @notice Unpauses functionality by specific type when pause period has expired. |
There was a problem hiding this comment.
Suggested change
| * @notice Unpauses functionality by specific type when pause period has expired. | |
| * @notice Unpauses functionality by pause type when pause period has expired. |
| /// @dev Note: This was reduced previously to cater for new functionality. | ||
| uint256[7] private __gap; | ||
| /// @dev Do not add any new storage variables to the contract. Instead add new variables to the PauseManagerStorage struct. | ||
| /// @dev __gap is deprecated in favour of the ERC-7201 Namespaced Storage pattern |
There was a problem hiding this comment.
Suggested change
| /// @dev __gap is deprecated in favour of the ERC-7201 Namespaced Storage pattern | |
| /// @dev __gap is deprecated in favor of the ERC-7201 Namespaced Storage pattern and remains for layout structure. |
Comment on lines
+163
to
+164
| bool isSecurityCouncil = hasRole(SECURITY_COUNCIL_ROLE, _msgSender()); | ||
| if (isSecurityCouncil) { |
There was a problem hiding this comment.
Suggested change
| bool isSecurityCouncil = hasRole(SECURITY_COUNCIL_ROLE, _msgSender()); | |
| if (isSecurityCouncil) { | |
| if (hasRole(SECURITY_COUNCIL_ROLE, _msgSender())) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist